[RFC] FILTER_THROW_ON_FAILURE #18896
Draft
+453
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielEScherzer
changed the title
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
8c5abca to
86969e5
Compare
divinity76
reviewed
Jun 22, 2025
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
86969e5 to
10dab9e
Compare
divinity76
reviewed
Jul 6, 2025
| #define RETURN_VALIDATION_FAILED \ | ||
| if (EG(exception)) { \ | ||
| return; \ | ||
| return SUCCESS; \ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, this should be success, because success here means that we shouldn't create a new exception for the filter failure
|
LGTM fwiw. (I don't have access use the actual github review form on php-src, but it lgtm.) |
derickr
reviewed
Jul 14, 2025
| zend_throw_exception_ex( | ||
| php_filter_failed_exception_ce, | ||
| 0, | ||
| "filter validation failed: filter %s not satisfied by %s", |
There was a problem hiding this comment.
Would it make sense to use ' around the %s's? In the error message, you can now end up with a phrase like:
filter validation failed: filter %s not satisfied by elephpants
Which reads as a joke... as it's unclear whether elephpants are the variable contents that the filter is operating on.
| zend_throw_exception_ex( | ||
| php_filter_failed_exception_ce, | ||
| 0, | ||
| "filter validation failed: not an array (got %s)", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/filter_throw_on_failure